Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: [IOBP-833] Sorting algorithms for PSP bundles #6382

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

chore: [IOBP-833] Sorting algorithms for PSP bundles #6382

wants to merge 49 commits into from

Conversation

LeleDallas
Copy link
Contributor

Short description

This pull request updating the sorting algorithm for PSP bundles

  • Updated sorting logic in getSortedPspList function:

List of changes proposed in this pull request

  • Updated sorting logic in getSortedPspList function

How to test

  • Tap in Inquadra and try to pay something
  • Select a payment method
  • Check PSP bundles list
  • Tap on Ordina
  • Tap on a radio button to select a sorting option, then verify that the list is sorted correctly according to the chosen algorithm

Preview

Screen.Recording.2024-11-06.at.17.12.02.mov

@LeleDallas LeleDallas added the IO-Bonus e pagamenti IO - Bonus e pagamenti label Nov 7, 2024
@pagopa-github-bot pagopa-github-bot changed the title refactor: [IOBP-833] Sorting algorithms for PSP bundles chore: [IOBP-833] Sorting algorithms for PSP bundles Nov 7, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Nov 7, 2024 •
edited by jira bot
Loading

Affected stories

  • ⚙️ IOBP-833: [Improvement] Adeguamento a nuove logiche di ordinamento GEC
    subtask of
    • ⚡ IOBP-701: Evolutive flusso di on-boarding/pagamento

Generated by 🚫 dangerJS against e09e78b

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 30.56%. Comparing base (f739c10) to head (9d11d1f).

Files with missing lines Patch % Lines
...features/payments/checkout/store/reducers/index.ts 0.00% 4 Missing ⚠️
.../payments/checkout/hooks/useSortPspBottomSheet.tsx 0.00% 3 Missing ⚠️
...ts/checkout/screens/WalletPaymentPickPspScreen.tsx 0.00% 2 Missing ⚠️
ts/features/payments/common/utils/index.ts 0.00% 2 Missing ⚠️
...ents/checkout/components/WalletPspListSkeleton.tsx 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (f739c10) and HEAD (9d11d1f). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (f739c10) HEAD (9d11d1f)
10 3
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #6382       +/-   ##
===========================================
- Coverage   49.29%   30.56%   -18.74%     
===========================================
  Files        1555     1521       -34     
  Lines       32122    31598      -524     
  Branches     7313     7190      -123     
===========================================
- Hits        15834     9657     -6177     
- Misses      16238    21903     +5665     
+ Partials       50       38       -12
Files with missing lines Coverage Δ
...ents/checkout/components/WalletPspListSkeleton.tsx 33.33% <0.00%> (ø)
...ts/checkout/screens/WalletPaymentPickPspScreen.tsx 3.07% <0.00%> (ø)
ts/features/payments/common/utils/index.ts 29.87% <0.00%> (-10.39%) ⬇️
.../payments/checkout/hooks/useSortPspBottomSheet.tsx 18.18% <0.00%> (ø)
...features/payments/checkout/store/reducers/index.ts 18.98% <0.00%> (-4.77%) ⬇️

... and 493 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f739c10...9d11d1f. Read the comment docs.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

Jira Pull Request Link

This Pull Request refers to the following Jira issue IOBP-833

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hantex9 Hantex9 Hantex9 approved these changes

@ChrisMattew ChrisMattew Awaiting requested review from ChrisMattew ChrisMattew is a code owner

@gispada gispada Awaiting requested review from gispada gispada is a code owner

@freddi301 freddi301 Awaiting requested review from freddi301 freddi301 is a code owner

Assignees

@LeleDallas LeleDallas

Labels
dont-merge ✋ IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LeleDallas @pagopa-github-bot @Hantex9